Conversation
AndriySvyryd
force-pushed
the
CoreCleanup
branch
from
0f23b7e to
3e9ca2d
Compare
roji
reviewed
Aug 13, 2025
src/EFCore/Metadata/Conventions/NonNullableReferencePropertyConvention.cs
Show resolved
Hide resolved
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.Expressions.cs
Show resolved
Hide resolved
src/EFCore/Query/Internal/QueryableMethodNormalizingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
roji
approved these changes
Aug 13, 2025
Merged
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive code cleanup across Entity Framework Core (EFCore) shared utilities and core components. The changes modernize the codebase by utilizing newer C# language features, improving code consistency, and enhancing readability.
Key Changes:
- Modernized collection initializations using collection expressions (
[]syntax) - Converted to file-scoped namespaces throughout shared utilities
- Applied field-backed property patterns using the
fieldcontextual keyword - Simplified LINQ expressions and method calls by removing unnecessary multi-line formatting
Reviewed Changes
Copilot reviewed 193 out of 201 changed files in this pull request and generated 3 comments.
:
| File | Description |
|---|---|
| src/Shared/*.cs | Modernized shared utilities with file-scoped namespaces, collection expressions, and field-backed properties |
| src/EFCore/Storage/*.cs | Updated value converter classes to use field-backed properties and improved API documentation |
| src/EFCore/Query/*.cs | Simplified LINQ expressions and applied modern C# patterns |
| src/EFCore/Metadata/*.cs | Extensive modernization of metadata classes with field-backed properties and improved code organization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.